965156 - Cannot upload full theme

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[dkgo]

Attachment: aa.png

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140128132521

Steps to reproduce:

fxchrome Cannot upload.
get error

No such issues on theme.




Actual results:

Error with fxchrome.xpi
100% complete · 3.49 MB of 3.49 MB
Your add-on failed validation with 4 errors.

    The `#downloads-indicator` node was removed from the DOM.
    The `#downloads-indicator` node was removed from the DOM.
    The `#downloads-indicator` node was removed from the DOM.
    The `#downloads-indicator` node was removed from the DOM.

Comment 1

[dkgo]

#downloads-indicator working on fiefox26

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think Validation is a better fit for this than the now-deprecated Builder component.

Comment 3

[Aris]

I can confirm this one. Validator even refuses already fully reviewed files, if you try to (re)upload them.
Whose idea was to block valid ids like '#downloads-indicator' only because they got removed from 'recent' Fx builds?

It should not be validators business which ids an add-on uses. The reviewer has to put a note, if an id violates something or leads to incompatibilities.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Bug 961270 should've added this as an error for compatibility bumps, but not for all validations.

Comment 5

[Mark Striemer [:mstriemer]]

https://github.com/mozilla/amo-validator/commit/cd0edd7f81bb83be810002023730a3a762f27d79